Re: [PATCH] ARC: uaccess: get_user to zero out dest in cause of fault
From: H. Peter Anvin
Date: Mon Aug 22 2016 - 19:51:42 EST
On August 22, 2016 4:48:00 PM PDT, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>On Mon, Aug 22, 2016 at 4:12 PM, H. Peter Anvin <hpa@xxxxxxxxx> wrote:
>>
>> How about the gcc native __builtin_setjmp stuff which is supposedly
>better?
>
>How new is it? The whole point was that we'd not have to worry and
>wait for gcc features..
>
>glibc doesn't use it, which worries me a bit. Has it ever gotten any
>use/testing?
>
>But yes, the compiler could do better. If we can rely on it, and it
>doesn't do stupid things (like have signal state etc crap - glibc
>seems to just alias "setjmp" to "sigsetjmp" with a "didn't save
>signals" flag)
>
> Linus
We can always fall back on the classic implementation for older gcc, just like we do for so many other features.
--
Sent from my Android device with K-9 Mail. Please excuse brevity and formatting.