Re: [PATCH v05 27/72] linux/if.h linux/hdlc/ioctl.h: move IFNAMSIZ definition to hdlc/ioctl.h

[David Miller]

From: Frans Klaver <fransklaver@xxxxxxxxx>
Date: Tue, 23 Aug 2016 09:03:20 +0200

> On Tue, Aug 23, 2016 at 1:30 AM, David Miller <davem@xxxxxxxxxxxxx> wrote:
>> From: Mikko Rapeli <mikko.rapeli@xxxxxx>
>> Date: Mon, 22 Aug 2016 20:32:44 +0200
>>
>>> Fixes userspace compiler error:
>>>
>>> error: ʽIFNAMSIZʼ undeclared here (not in a function)
>>>
>>> Suggested by Frans Klaver <fransklaver@xxxxxxxxx> on lkml message
>>> <20150530195223.GA15645@xxxxxxxxxxx>.
>>>
>>> Signed-off-by: Mikko Rapeli <mikko.rapeli@xxxxxx>
>>
>> IFNAMSIZ has to be in linux/if.h, you aren't explaining why you have
>> to move it to the hdlc header instead of having the hdlc header
>> include linux/if.h
> 
> Circular references. linux/if.h includes hdlc/ioctl.h, and has to
> define IFNAMSIZ before doing so.

That's not acceptable.  Use forward declarations or similar to avoid
the circular dependency.

IFNAMSIZ belongs in linux/if.h, please keep it there.