Re: [PATCH 3/7] libfs: support RENAME_NOREPLACE in simple_rename()
From: Greg Kroah-Hartman
Date: Tue Aug 23 2016 - 10:46:58 EST
On Tue, Aug 23, 2016 at 04:05:28PM +0200, Miklos Szeredi wrote:
> This is trivial to do:
>
> - add flags argument to simple_rename()
> - check if flags doesn't have any other than RENAME_NOREPLACE
> - assign simple_rename() to .rename2 instead of .rename
>
> Filesystems converted:
>
> hugetlbfs, ramfs, bpf.
>
> Debugfs uses simple_rename() to implement debugfs_rename(), which is for
> debugfs instances to rename files internally, not for userspace filesystem
> access. For this case pass zero flags to simple_rename().
>
> Signed-off-by: Miklos Szeredi <mszeredi@xxxxxxxxxx>
> Cc: Alexei Starovoitov <ast@xxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>