Re: [PATCH 0/3] acpi, nfit: nvdimm notification support + tests
From: Vishal Verma
Date: Tue Aug 23 2016 - 18:40:49 EST
On 08/23, Dan Williams wrote:
> ACPI 6.1 added an "NFIT Health Event Notification" for nvdimm devices.
> When this fires, system software is expected to issue a DSM to retrieve
> the latest health values. For the NFIT driver this notification
> arrives as an event on the sysfs 'flags' attribute for an nfit/nvdimm
> device. The 'flags' attribute reflects the "NVDIMM State Flags" of the
> "5.2.25.3 NVDIMM Region Mapping Structure", and when read indicates if
> the platform supports sending health events.
>
> ---
>
> Dan Williams (3):
> tools/testing/nvdimm: unit test for acpi_nfit_notify()
> acpi, nfit: add dimm device notification support
> tools/testing/nvdimm: unit test for acpi_nvdimm_notify()
>
>
> drivers/acpi/nfit/core.c | 112 ++++++++++++++++++++++++++++++++-----
> drivers/acpi/nfit/nfit.h | 7 ++
> drivers/nvdimm/dimm_devs.c | 6 ++
> include/linux/libnvdimm.h | 1
> tools/testing/nvdimm/Kbuild | 1
> tools/testing/nvdimm/test/iomap.c | 17 ++++++
> tools/testing/nvdimm/test/nfit.c | 64 +++++++++++++++++++--
> 7 files changed, 188 insertions(+), 20 deletions(-)
Looks good to me. For the series,
Reviewed-by: Vishal Verma <vishal.l.verma@xxxxxxxxx>