Re: [PATCH v2 2/2] firmware_class: Use swait instead of completion

[Luis R. Rodriguez]

On Tue, Aug 23, 2016 at 11:00:20AM +0200, Daniel Wagner wrote:
> From: Daniel Wagner <daniel.wagner@xxxxxxxxxxxx>
> 
> complete_all() can only be issued once before it needs to be
> reinitialized. 

What are the chances this ever happened? If it could not happen its
worth explaining why.

> To ensure we never call complete_all() twice we use
> swait and make the code here a bit more robust.

The real benefit here though is not that is it? Isn't the benefit that
we don't need all the API functionality provided by wait, we just need
something light weight.

Thanks for splitting this up, it makes it for a much easier review.

  Luis