Re: [Patch v8] driver/clk/clk-si5338: Add common clock framework driver for si5338

From: kbuild test robot
Date: Tue Aug 23 2016 - 20:12:13 EST


Hi York,

[auto build test WARNING on clk/clk-next]
[also build test WARNING on v4.8-rc3 next-20160823]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
[Suggest to use git(>=2.9.0) format-patch --base=<commit> (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on]
[Check https://git-scm.com/docs/git-format-patch for more information]

url: https://github.com/0day-ci/linux/commits/York-Sun/driver-clk-clk-si5338-Add-common-clock-framework-driver-for-si5338/20160824-064316
base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
config: x86_64-allmodconfig (attached as .config)
compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64

All warnings (new ones prefixed by >>):

drivers/clk/clk-si5338.c: In function 'clkout_status_show':
>> drivers/clk/clk-si5338.c:2843:3: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
if (drv_configs[j].fmt == drv_type &&
^~
drivers/clk/clk-si5338.c:2850:4: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
match = 1;
^~~~~

vim +/if +2843 drivers/clk/clk-si5338.c

2827 if (drv_type < 0)
2828 return drv_type;
2829
2830 drv_vdd = get_drv_vdd(drvdata, i);
2831 if (drv_vdd < 0)
2832 return drv_vdd;
2833
2834 drv_trim = get_drv_trim(drvdata, i);
2835 if (drv_trim < 0)
2836 return drv_trim;
2837
2838 drv_invert = get_drv_invert(drvdata, i);
2839 if (drv_invert < 0)
2840 return drv_invert;
2841
2842 for (j = 0; drv_configs[j].description; j++) {
> 2843 if (drv_configs[j].fmt == drv_type &&
2844 drv_configs[j].vdd == drv_vdd &&
2845 drv_configs[j].trim == drv_trim &&
2846 (drv_invert | (drv_configs[j].invert >> 2)) ==
2847 ((drv_configs[j].invert & 3) |
2848 (drv_configs[j].invert>>2)))
2849 seq_puts(s, drv_configs[j].description);
2850 match = 1;
2851 }

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: Binary data