Re: [PATCH 1/3] net: fs_enet: merge NAPI RX and NAPI TX

From: Eric Dumazet
Date: Wed Aug 24 2016 - 09:15:55 EST


On Wed, 2016-08-24 at 06:07 -0700, Eric Dumazet wrote:

> I am afraid you could live lock here on SMP.
>
> You should make sure you do not loop forever, not assuming cpu is faster
> than NIC.

You are protected by the tx_lock spinlock, but this is fragile as you
could very well remove this spinlock in the future to get lockless
transmit, like many other drivers.