Re: [PATCH 3/6] x86/dumpstack: make printk_stack_address() more generally useful
From: Linus Torvalds
Date: Wed Aug 24 2016 - 14:38:57 EST
On Wed, Aug 24, 2016 at 2:22 PM, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> I actively disable KASLR on my dev box and feed these hex numbers into
> addr2line -ie vmlinux to find where in the function we are.
> Having the option to make %pB generate them works for me.
Yeah, considering that this is the only place this is used, changing
%pB sounds quite reasonable.
We could perhaps make %pB show the hex numbers and address (so pB
would expand to "[<hex>] symbolname".if
(a) not randomizing (so the hex numbers _may_ be useful)
(b) kptr_restrict is 0 (so the hex numbers are "safe" in the dmesg)
and fall back to just the symbolic name if either of those aren't true?
And obviously, if KALLSYMS isn't enabled, you always show hex
numbers.. That's already the case (but we might want to add the "[<>}'
markers around the hex numbers just to make the user space automation
we do have work).