Re: [PATCH 1/2] clk: samsung: exynos5260: Move struct samsung_cmu_info to init section

From: Stephen Boyd
Date: Thu Aug 25 2016 - 00:58:09 EST


On 08/24, Chanwoo Choi wrote:
> On 2016ë 08ì 24ì 13:43, Stephen Boyd wrote:
> > On 08/23, Sylwester Nawrocki wrote:
> >> So the saving is rather insignificant but the patch doesn't make
> >> things worse and I'd say it might be worth applying.
> >>
> >
> > Sounds good. This sort of information should be in the commit
> > text though. Talking about const doesn't make any sense to me.
>
> Do you mean that 'const' is initconst secion?

No. Marking it as initconst in the patch is correct.

> If possible, could you explain the anything
> why you don't make sense about 'const'?
>

I'm just saying that the reasoning to move it from the text
section to the data section shouldn't be because of const. There
should be better reasons to do this, like size benefits.

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project