Re: [PATCH] usbnet: ax88179_178a: Add support for writing the EEPROM

From: Oliver Neukum
Date: Thu Aug 25 2016 - 05:21:42 EST


On Wed, 2016-08-24 at 16:40 +0200, Alban Bedel wrote:
> On Wed, 24 Aug 2016 16:30:39 +0200
> Oliver Neukum <oneukum@xxxxxxxx> wrote:
>
> > On Wed, 2016-08-24 at 15:52 +0200, Alban Bedel wrote:

> > > + if (block != data)
> > > + kfree(block);
> >
> > And if block == dta, what frees the memory?
>
> In this case this function didn't allocate any memory, so there is
> nothing to free.

Hi,

I see. kfree() has a check for NULL, so you could drop the
test, but it doesn't matter much either way.

Regards
Oliver