Re: [PATCH 4.7 146/186] floppy: fix open(O_ACCMODE) for ioctl-only open

[Mark Hounschell]

On 08/24/2016 05:11 PM, Jiri Kosina wrote:
> On Wed, 24 Aug 2016, Greg Kroah-Hartman wrote:
>
> > > I have a problem with this patch. It only fixes one of the regressions
> > > caused by the original change to the floppy driver. It does not address the
> > > user land breakage of removing the NODELAY flag checks.
> >
> > Does the same problem also happen in Linus's tree?  If not, any hints on
> > the patch that might have fixed it there?

Yes, it does. IMHO the entire patch (between 4.4 and 4.5 that broke user 
land multiple ways) should be reverted and a fix for what ever obscure 
BUG was supposed to be fixed should be "retried".

> That's still an unresolved issue, and it's on my list to things to look
> into.
>
> This particular patch though fixes a different issue, and should be
> applied to -stable.

This patch fixes a bug that was introduced to fix "some other obscure 
BUG" that has nothing to do whatever with the "physical floppy" device. 
And it broke user land in at least 2 ways. All this patch does is revert 
part of the original patch so that it is only broke in 1 way to user 
land. It should revert the whole thing IMHO.

Regards
Mark

> Thanks,