Re: [PATCH] spi: qup: skip clk_disable_unprepare if the device is already runtime suspended

From: Sudeep Holla
Date: Thu Aug 25 2016 - 09:37:35 EST


Hi Andy,

On 25/08/16 14:26, Andy Gross wrote:
On Thu, Aug 25, 2016 at 01:33:28PM +0100, Sudeep Holla wrote:
If the spi device is already runtime suspended, if spi_qup_suspend is
executed during suspend-to-idle or suspend-to-ram it will result in the
following splat:

WARNING: CPU: 3 PID: 1593 at drivers/clk/clk.c:476 clk_core_unprepare+0x80/0x90
Modules linked in:


<snip>

Thanks for fixing this. I had noticed this yesterday when I was testing your
freeze patch but hadn't had time to dig in.


Yes, even I tested the same once I got PSCI firmware :)


Tested-by: Andy Gross <andy.gross@xxxxxxxxxx>


Thanks.

--
Regards,
Sudeep