Re: [PATCH for-next 0/2] {IB,net}/hns: Add support of ACPI to the Hisilicon RoCE Driver

[Doug Ledford]

On 8/25/2016 8:00 AM, Salil Mehta wrote:
> 
> 
>> -----Original Message-----
>> From: David Miller [mailto:davem@xxxxxxxxxxxxx]
>> Sent: Thursday, August 25, 2016 5:54 AM
>> To: Salil Mehta
>> Cc: dledford@xxxxxxxxxx; Huwei (Xavier); oulijun; Zhuangyuzeng (Yisen);
>> mehta.salil.lnk@xxxxxxxxx; linux-rdma@xxxxxxxxxxxxxxx;
>> netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Linuxarm
>> Subject: Re: [PATCH for-next 0/2] {IB,net}/hns: Add support of ACPI to
>> the Hisilicon RoCE Driver
>>
>> From: Salil Mehta <salil.mehta@xxxxxxxxxx>
>> Date: Wed, 24 Aug 2016 04:44:48 +0800
>>
>>> This patch is meant to add support of ACPI to the Hisilicon RoCE
>> driver.
>>> Following changes have been made in the driver(s):
>>>
>>> Patch 1/2: HNS Ethernet Driver: changes to support ACPI have been
>> done in
>>>    the RoCE reset function part of the HNS ethernet driver. Earlier
>> it only
>>>    supported DT/syscon.
>>>
>>> Patch 2/2. HNS RoCE driver: changes done in RoCE driver are meant to
>> detect
>>>    the type and then either use DT specific or ACPI spcific
>> functions. Where
>>>    ever possible, this patch tries to make use of "Unified Device
>> Property
>>>    Interface" APIs to support both DT and ACPI through single
>> interface.
>>>
>>> NOTE 1: ACPI changes done in both of the drivers depend upon the ACPI
>> Table
>>>      (DSDT and IORT tables) changes part of UEFI/BIOS. These changes
>> are NOT
>>>      part of this patch-set.
>>> NOTE 2: Reset function in Patch 1/2 depends upon the reset function
>> added in
>>>      ACPI tables(basically DSDT table) part of the UEFI/BIOS. Again,
>> this
>>>      change is NOT reflected in this patch-set.
>>
>> I can't apply this series to my tree because the hns infiniband driver
>> doesn't exist in it.
> Hi David,
> I understand your point. This patch-set was primarily sent for Doug Ledford
> and is based on his internal repository (which has been rebased on the
> net-next). 
> 
> Though we were hoping, if by any chance, we can expedite the acceptance of the
> below patch part of patch-set in the net-next. This might help Doug Ledford as
> well later on when he pushes the already accepted RoCE driver and ACPI patches
> to linux-next,
> 
> "[PATCH for-next 1/2] net: hns: Add support of ACPI to HNS driver RoCE Reset
>  function"
> 
> Below HNS RoCE reset function patch has already been accepted and is part of your
> net-next,
> https://patchwork.kernel.org/patch/9287497/
> 
> Above ACPI support of RoCE Reset patch cleanly applies over the already accepted
> patch in the link. It is not dependent on other accompanying RoCE driver ACPI
> changes related patch or even the presence of the Infiniband/RoCE Driver in the
> net-next repository.
> 
> Could you please suggest anything here?  
> 
> Thanks 
> Salil
> 

I can take both.  I already pulled net-next to get the initial hns roce
reset patch from Dave, so these will apply cleanly with my tree and
merge cleanly with Dave's due to the common ancestral base.  The only
problem is that if you intend to send any other patches that effect this
code, then they would need to come through me until the 4.9 merge window
is complete so that we don't have later merge conflicts.

-- 
Doug Ledford <dledford@xxxxxxxxxx>
    GPG Key ID: 0E572FDD

Attachment: signature.asc
Description: OpenPGP digital signature