Re: [PATCH v2] livepatch/module: make TAINT_LIVEPATCH module-specific
From: Petr Mladek
Date: Thu Aug 25 2016 - 11:11:45 EST
On Thu 2016-08-25 10:04:45, Josh Poimboeuf wrote:
> There's no reliable way to determine which module tainted the kernel
> with TAINT_LIVEPATCH. For example, /sys/module/<klp module>/taint
> doesn't report it. Neither does the "mod -t" command in the crash tool.
> Make it crystal clear who the guilty party is by associating
> TAINT_LIVEPATCH with any module which sets the "livepatch" modinfo
> attribute. The flag will still get set in the kernel like before, but
> now it also sets the same flag in mod->taint.
> Note that now the taint flag gets set when the module is loaded rather
> than when it's enabled.
> I also renamed find_livepatch_modinfo() to check_modinfo_livepatch() to
> better reflect its purpose: it's basically a livepatch-specific
> sub-function of check_modinfo().
> Reported-by: Chunyu Hu <chuhu@xxxxxxxxxx>
> Signed-off-by: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
Everything looks fine now.
Reviewed-by: Petr Mladek <pmladek@xxxxxxxx>