Re: [PATCH 6/6] staging: comedi: ni_at_a2150.c: Fix checkpatch warning
From: Andrey Utkin
Date: Thu Aug 25 2016 - 12:19:47 EST
On Thu, Aug 25, 2016 at 12:09:23PM -0400, Anson Jacob wrote:
> On Thu, Aug 25, 2016 at 06:47:08PM +0300, Andrey Utkin wrote:
> > > +#define CHANNEL_BITS(x) ((x) & 0x7)
> > > +#define CHANNEL_MASK 0x7
> > No uniform alignment. Please get everything in a row.
> > If it's hard or this part of driver is expected to have a lot of changes
> > in near future, then I'd remove any whitespace over single space between
> > name and value.
> I didn't get your point in this case. Could you explain it.
Reviewing actual source code with the patch applied, it looks well. But
if you look at the patch email itself, or in "git show <commit>, the
alignment is broken. This is an illustration why using tab characters in
the middle of lines is bad idea. However this is what I see in lots of
So feel free to ignore this point.