Re: [PATCH 2/3] acpi, nfit: add dimm device notification support

From: Kani, Toshimitsu
Date: Fri Aug 26 2016 - 14:26:35 EST

On Tue, 2016-08-23 at 14:54 -0700, Dan Williams wrote:
> Per "ACPI 6.1 Section 9.20.3" NVDIMM devices, children of the
> ACPI0012 NVDIMM Root device, can receive health event notifications.
> Given that these devices are precluded from registering a
> notification handler via acpi_driver.acpi_device_ops (due to no
> _HID), we use acpi_install_notify_handler() directly.ÂÂ

I've confirmed that this ACPI notify handler is called properly.

> The registered handler, acpi_nvdimm_notify(), triggers a poll(2)
> event on the nmemX/nfit/flags sysfs attribute when a health event
> notification is received.

This sounds good idea, but should we document that the value of sysfs
'flags' itself does not get updated? ÂUser space program will then need
to call its _DSM to get health status.