Re: [PATCH] IB/mlx5: Fix a parameter of find_first_bit
From: Leon Romanovsky
Date: Fri Aug 26 2016 - 15:33:14 EST
On Fri, Aug 26, 2016 at 07:16:17AM +0200, Christophe JAILLET wrote:
> The 2nd parameter of 'find_first_bit' is the number of bits to search.
> In this case, we are passing 'sizeof(tmp)' which is likely to be 4 or 8
> because 'tmp' is an 'unsigned long'.
> It is likely that the number of bits of 'tmp' was expected here. So use
> BITS_PER_LONG instead.
> It has been spotted by the following coccinelle script:
> expression ret, x;
> * ret = \(find_first_bit \| find_first_zero_bit\) (x, sizeof(...));
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
Acked-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
Description: PGP signature