Re: [RFC v4 14/22] clockevents: clockevents_program_event(): turn clc into unsigned long

From: Nicolai Stange
Date: Sat Aug 27 2016 - 11:23:25 EST


Thomas Gleixner <tglx@xxxxxxxxxxxxx> writes:

> On Tue, 23 Aug 2016, Nicolai Stange wrote:
>
>> Right now, being of type unsigned long long, the clc local variable in
>> clockevents_program_event() is unnecessarily wide as it gets cast to
>> unsigned long anyway.
>
> Congrats! You just broke 32bit systems. When delta is sufficiently large then
> the mult overflows....

The 32bit breakage has been introduced in [13/22] ("clockevents: check a
programmed delta's bounds in terms of cycles") already -- please see my
reply there.