Re: [PATCH 3/6] rtl8188eu: declare internal function as static

[Andy Shevchenko]

On Sat, 2016-08-27 at 14:40 +0200, Luca Ceresoli wrote:

Put here few words _why_ you are doing this.
Perhaps, add output of sparse static analyzer.

> Signed-off-by: Luca Ceresoli <luca@xxxxxxxxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: Bhaktipriya Shridhar <bhaktipriya96@xxxxxxxxx>
> Cc: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Cc: Geliang Tang <geliangtang@xxxxxxx>
> Cc: Jakub Sitnicki <jsitnicki@xxxxxxxxx>
> Cc: Ivan Safonov <insafonov@xxxxxxxxx>
> Cc: Kyle Kuffermann <kyle.kuffermann@xxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> ---
> Âdrivers/staging/rtl8188eu/core/rtw_recv.c | 4 ++--
> Â1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c
> b/drivers/staging/rtl8188eu/core/rtw_recv.c
> index 977bb2532c3e..1063617b0ce4 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_recv.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_recv.c
> @@ -39,7 +39,7 @@ static u8 rtw_rfc1042_header[] = {
> ÂÂÂÂÂÂÂÂ0xaa, 0xaa, 0x03, 0x00, 0x00, 0x00
> Â};
> Â
> -void rtw_signal_stat_timer_hdl(unsigned long data);
> +static void rtw_signal_stat_timer_hdl(unsigned long data);
> Â
> Âvoid _rtw_init_sta_recv_priv(struct sta_recv_priv *psta_recvpriv)
> Â{
> @@ -2088,7 +2088,7 @@ _recv_entry_drop:
> Â	return ret;
> Â}
> Â
> -void rtw_signal_stat_timer_hdl(unsigned long data)
> +static void rtw_signal_stat_timer_hdl(unsigned long data)
> Â{
> Â	struct adapter *adapter = (struct adapter *)data;
> Â	struct recv_priv *recvpriv = &adapter->recvpriv;

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy