Re: [PATCH v1 4/5] ARM: dts: ls1043a: add qDMA node

From: Alexander Stein
Date: Mon Aug 29 2016 - 03:29:59 EST


On Thursday 18 August 2016 14:38:47, Yuan Yao wrote:
> From: Yuan Yao <yao.yuan@xxxxxxx>
>
> Add the QDMA node for ls1043a platform to
> support QDMA driver.
>
> Signed-off-by: Yuan Yao <yao.yuan@xxxxxxx>
> ---
> arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi index e8e4c3e..e463074
> 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> @@ -467,6 +467,16 @@
> <&clockgen 4 0>;
> };
>
> + qdma: qdma@8390000 {
> + compatible = "fsl,ls1021a-qdma", "fsl,ls1043a-qdma";

This doesn't match the order of your binding in Patch 2/5:
> +- compatible :
> + - "fsl,ls1021a-qdma",
> + Or "fsl,ls1043a-qdma" followed by "fsl,ls1021a-qdma",

It should be the other way around.

Best regards,
Alexander