Re: [PATCH] fix:mailbox:bcm-pdc-mailbox:mark symbols static where possible

From: Arnd Bergmann
Date: Mon Aug 29 2016 - 07:00:31 EST


On Sunday, August 28, 2016 1:15:24 AM CEST Baoyou Xie wrote:
> We get 2 warnings when biuld kernel with W=1:
> drivers/mailbox/bcm-pdc-mailbox.c:472:6: warning: no previous prototype for 'pdc_setup_debugfs' [-Wmissing-prototypes]
> drivers/mailbox/bcm-pdc-mailbox.c:488:6: warning: no previous prototype for 'pdc_free_debugfs' [-Wmissing-prototypes]
>
> In fact, these functions are only used in the file in which they are
> declared and don't need a declaration, but can be made static.
> so this patch marks these functions with 'static'.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@xxxxxxxxxx>
>

Acked-by: Arnd Bergmann <arnd@xxxxxxxx>