Re: [PATCH v2] mtd: spi-nor: Add s25fs256s1 spi-nor flash support

[Jagan Teki]

On Wed, Aug 17, 2016 at 2:27 PM, Yunhui Cui <yunhui.cui@xxxxxxx> wrote:
>
> On Monday, August 08, 2016 3:22 AM, Jagan Teki wrote:
>
>> Add Spansion s25fs256s1 spi-nor flash to the list of spi_nor_ids.
>>
>> In spansion S25FS-S family the physical sectors are grouped as normal and
>> parameter sectors. Parameter sectors are 4kB in size with 8 set located
>> at the bottom or top address of a device.
>> Normal sectors are similar to other flash family with sizes of 64kB or 32
>> kB.
>>
>> To erase whole flash using sector erase(D8h or DCh) won't effect the
>> parameter sectors, so in order to erase these we must use 4K sector erase
>> commands (20h or 21h) separately.
>>
>> So better to erase the whole flash using 4K sector erase instead of
>> detecting these family parts again and do two different erase operations.
>>
>> Cc: Brian Norris <computersforpeace@xxxxxxxxx>
>> Cc: Yunhui Cui <yunhui.cui@xxxxxxx>
>> Cc: Michael Trimarchi <michael@xxxxxxxxxxxxxxxxxxxx>
>> Signed-off-by: Jagan Teki <jteki@xxxxxxxxxxxx>
>> ---
>> Changes for v2:
>>       - Fix wrong vendor name in commit message
>
> [Yunhui] Actually, This flash is belongs to S25FS-S Family, besides,
> S25FS128S 128 Mbit (16 Mbyte)
> S25FS256S 256 Mbit (32 Mbyte)
> S25FS512S 512 Mbit (64 Mbyte)
> They need some specific operations, not the Spansion S25FL128S Family.

Please point what exactly the specific ops? because I observed S25FL
vs S25FS have change in a way that they erase the whole flash.

-- 
Jagan Teki.