Re: [PATCH 0/4 v2] Audio support for adv7511 hdmi bridge

From: Laurent Pinchart
Date: Tue Aug 30 2016 - 05:22:44 EST


Hi John,

Thank you for the patches.

On Monday 29 Aug 2016 16:41:32 John Stultz wrote:
> This is another swing at getting the adv7511 hdmi bridge
> audio support reviewed.
>
> I've taken the core audio work done by Lars-Peter Clausen, and
> adapted by Srinivas Kandagatla and Archit Taneja, and tried to
> rework it to use the hdmi-codec sound driver.
>
> This patchset, along with the i2s driver and dts changes allows
> HDMI audio to work on the HiKey board.

Where are the dts changes ?

> I'd really appreciate any thoughts or feedback.
>
> New in v2:
> * Integrated Srinivas' review feedback
>
> thanks
> -john
>
> Cc: David Airlie <airlied@xxxxxxxx>
> Cc: Archit Taneja <architt@xxxxxxxxxxxxxx>
> Cc: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> Cc: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
> Cc: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
> Cc: "Ville Syrjälä" <ville.syrjala@xxxxxxxxxxxxxxx>
> Cc: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx>
> Cc: Andy Green <andy@xxxxxxxxxxx>
> Cc: Dave Long <dave.long@xxxxxxxxxx>
> Cc: Guodong Xu <guodong.xu@xxxxxxxxxx>
> Cc: Zhangfei Gao <zhangfei.gao@xxxxxxxxxx>
> Cc: Mark Brown <broonie@xxxxxxxxxx>
> Cc: Lars-Peter Clausen <lars@xxxxxxxxxx>
> Cc: Jose Abreu <joabreu@xxxxxxxxxxxx>
> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
>
> Andy Green (1):
> drm/bridge: adv7511: Initialize audio packet on adv7533
>
> Archit Taneja (1):
> drm/bridge: adv7511: Move the common data structures to header file
>
> John Stultz (1):
> drm/bridge: adv7511: Add Audio support.
>
> Srinivas Kandagatla (1):
> drm/bridge: adv7511: Enable the audio data and clock pads on adv7533
>
> drivers/gpu/drm/bridge/adv7511/Kconfig | 1 +
> drivers/gpu/drm/bridge/adv7511/Makefile | 2 +-
> drivers/gpu/drm/bridge/adv7511/adv7511.h | 13 ++
> drivers/gpu/drm/bridge/adv7511/adv7511_audio.c | 199 ++++++++++++++++++++++
> drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 9 +-
> drivers/gpu/drm/bridge/adv7511/adv7533.c | 23 +++
> 6 files changed, 244 insertions(+), 3 deletions(-)
> create mode 100644 drivers/gpu/drm/bridge/adv7511/adv7511_audio.c

--
Regards,

Laurent Pinchart