Re: [PATCH 2/2] ARM: dts: sun8i-h3: Add UART1 pinctrl

[Milo Kim]

Hi Maxime,

On 08/26/2016 04:10 PM, Maxime Ripard wrote:
> Hi Milo,
>
> On Thu, Aug 25, 2016 at 03:44:54PM +0900, Milo Kim wrote:
> > In H3, PA5 can be used as PWM and UART0. If the PWM is used, the console
> > UART should be moved to other port.
> > This patch enables UART1 pinctrl to support this case.
> >
> > 	PA5: PWM
> > 	PG6, PG7: debug console
> >
> > Cc: Chen-Yu Tsai <wens@xxxxxxxx>
> > Cc: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx>
> > Cc: Rob Herring <robh+dt@xxxxxxxxxx>
> > Signed-off-by: Milo Kim <woogyom.kim@xxxxxxxxx>
> > ---
> >  arch/arm/boot/dts/sun8i-h3.dtsi | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi
> > index 3a965fb..fdb6801 100644
> > --- a/arch/arm/boot/dts/sun8i-h3.dtsi
> > +++ b/arch/arm/boot/dts/sun8i-h3.dtsi
> > @@ -526,6 +526,13 @@
> >  				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
> >  			};
> >
> > +			uart1_pins_a: uart1@0 {
> > +				allwinner,pins = "PG6", "PG7";
> > +				allwinner,function = "uart1";
> > +				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
> > +				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
> > +			};
> > +
>
> Our policy is that we don't introduce new pinctrl nodes that are not
> used by any board to avoid bloating the DT too much with unused nodes.
>
> If you have a board using it, please submit that change as well.

UART1 was already added in sun8i-h3.dtsi, so I drop this change in v2.

Commit-ID: 966c11a3b5e4

Best regards,
Milo