Re: [PATCH V7 5/5] perf tools: adding sink configuration for cs_etm PMU

From: Suzuki K Poulose
Date: Wed Aug 31 2016 - 05:38:49 EST


On 30/08/16 17:19, Mathieu Poirier wrote:
Using the PMU::set_drv_config() callback to enable the CoreSight
sink that will be used for the trace session.

+int cs_etm_set_drv_config(struct perf_evsel_config_term *term)
+{
+ int ret;
+ char enable_sink[ENABLE_SINK_MAX];
+
+ snprintf(enable_sink, ENABLE_SINK_MAX, "%s/%s",
+ term->val.drv_cfg, "enable_sink");
+
+ ret = cs_device__print_file(enable_sink, "%d", 1);
+ if (ret < 0)
+ return ret;
+
+ return 0;
+}


Don't we have to disable the sink at the end of the session ? How is that
taken care of ? Did I miss that ?

Suzuki