Re: [PATCH 07/34] mm, vmscan: make kswapd reclaim in terms of nodes
From: Mel Gorman
Date: Wed Aug 31 2016 - 08:47:11 EST
On Wed, Aug 31, 2016 at 01:09:33PM +0200, Michal Hocko wrote:
> > We cannot just convert populated_zone() as many existing users really
> > need to check for present_pages. This patch introduces a managed_zone()
> > helper and uses it in the few cases where it is critical that the check
> > is made for managed pages -- zonelist constuction and page reclaim.
> OK, the patch makes sense to me. I am not happy about two very similar
> functions, to be honest though. managed vs. present checks will be quite
> subtle and it is not entirely clear when to use which one.
In the vast majority of cases, the distinction is irrelevant. The patch
only updates the places where it really matters to minimise any
> Acked-by: Michal Hocko <mhocko@xxxxxxxx>
> * Returns true if a zone has pages managed by the buddy allocator.
> * All the reclaim decisions have to use this function rather than
> * populated_zone(). If the whole zone is reserved then we can easily
> * end up with populated_zone() && !managed_zone().
> What do you think?
This makes a lot of sense. I've updated the patch and will await a test
from Srikar before reposting.