Re: [PATCH net-next 1/3] net: dsa: add MDB support

From: Vivien Didelot
Date: Wed Aug 31 2016 - 10:58:06 EST


Hi Andrew,

Andrew Lunn <andrew@xxxxxxx> writes:

>> > Does the bridge code use multicast group when referring to L2?
>>
>> The switchdev MDB attribute is very similary to the FDB attribute. It
>> contains the VLAN ID and the Ethernet MAC address of the group.
>
> I'm just trying to avoid the use of 'multicast group' for a L2 entity,
> unless it is already widespread used so in the bridge code. If the
> bridge code does consider L2 a 'multciast group', fine, lets document
> it so. But if the bridge code only uses 'multciast group' to mean L3,
> we should not use it here for L2.

I am not quite sure about that. I can see that SWITCHDEV_OBJ_ID_PORT_MDB
is only crafted in net/bridge/br_mdb.c:__br_mdb_notify().

What should we do if the bridge code consider a multicast group as L3?

Thanks,

Vivien