Re: screen rotation flipped in 4.8-rc

From: Pandruvada, Srinivas
Date: Wed Aug 31 2016 - 16:30:05 EST


On Wed, 2016-08-31 at 13:24 -0700, Matt Ranostay wrote:
> On Wed, Aug 31, 2016 at 1:18 PM, Pandruvada, Srinivas
> <srinivas.pandruvada@xxxxxxxxx> wrote:
> >
> > On Tue, 2016-08-30 at 17:41 -0700, Matt Ranostay wrote:
> > >
> > > On Tue, Aug 30, 2016 at 3:42 PM, Pandruvada, Srinivas
> > > <srinivas.pandruvada@xxxxxxxxx> wrote:
> > > >
> > > >
> > > > Hi All,
> > > >
> > > > I observed that using iio-sensor-proxy.service, the auto screen
> > > > rotation flipped on my laptop (Normal -> vertical, vertical-
> > > > >
> > > > > normal)
> > > > using kernel v4.8.
> > > >
> > > > Anyone else has seen this?
> > > >
> > > > I did a bisect and found a commit, which I am not sure how can
> > > > it
> > > > impact.
> > > Could you post the results of CONFIG_TEST_HASH enabled?
> > Attached dmesg.txt with the CONFIG_TEST_HASH=y.
> >
> > I see
> > [ÂÂÂÂ4.276138] test_hash: __hash_32() has no arch implementation to
> > test.
> > [ÂÂÂÂ4.276138] test_hash: hash_32() has no arch implementation to
> > test.
> > [ÂÂÂÂ4.276139] test_hash: hash_64() has no arch implementation to
> > test.
> > [ÂÂÂÂ4.276141] test_hash: 33152 tests passed.
> >
> Ok have you tested with that patchset reverted? And if so does the
> regression disappear?
Yes, but not after adding CONFIG_TEST_HASH=y.
regression disappears.

> I would highly doubt if it was a issue with that dcache patchsets it
> wouldn't be breaking a ton of things.
I also think that.

Thanks,
Srinivas

>
> >
> > Thanks,
> > Srinivas
> > >
> > >
> > > Thanks,
> > >
> > > Matt
> > >
> > > >
> > > >
> > > >
> > > >
> > > > commit 703b5faf22fbddf984a361e6555f3a03fdba63d9
> > > > Author: George Spelvin <linux@xxxxxxxxxxxxxxxxxxx>
> > > > Date:ÂÂÂFri Jun 10 00:22:12 2016 -0400
> > > >
> > > > ÂÂÂÂfs/dcache.c: Save one 32-bit multiply in dcache lookup
> > > >
> > > > ÂÂÂÂNoe that we're mixing in the parent pointer earlier, we
> > > > ÂÂÂÂdon't need to use hash_32() to mix its bits.ÂÂInstead, we
> > > > can
> > > > ÂÂÂÂjust take the msbits of the hash value directly.
> > > >
> > > > ÂÂÂÂFor those applications which use the partial_name_hash(),
> > > > ÂÂÂÂmove the multiply to end_name_hash.
> > > >
> > > > ÂÂÂÂSigned-off-by: George Spelvin <linux@xxxxxxxxxxxxxxxxxxx>
> > > > ÂÂÂÂSigned-off-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxx
> > > > g>
> > > >
> > > >
> > > > Thanks,
> > > > Srinivas