Re: [PATCHv4 0/6] x86: 32-bit compatible C/R on x86_64

From: Dmitry Safonov
Date: Thu Sep 01 2016 - 04:56:23 EST


On 09/01/2016 09:18 AM, Ingo Molnar wrote:

* Dmitry Safonov <dsafonov@xxxxxxxxxxxxx> wrote:

Changes from v3:
- proper ifdefs around vdso_image_32
- missed Reviewed-by tag

arch/x86/entry/vdso/vma.c | 81 +++++++++++++++++++++++++++------------
arch/x86/ia32/ia32_signal.c | 2 +-
arch/x86/include/asm/compat.h | 8 ++--
arch/x86/include/asm/fpu/signal.h | 6 +++
arch/x86/include/asm/signal.h | 4 ++
arch/x86/include/asm/vdso.h | 2 +
arch/x86/include/uapi/asm/prctl.h | 6 +++
arch/x86/kernel/process_64.c | 25 ++++++++++++
arch/x86/kernel/ptrace.c | 2 +-
arch/x86/kernel/signal.c | 20 +++++-----
arch/x86/kernel/signal_compat.c | 34 ++++++++++++++--
fs/binfmt_elf.c | 23 ++++-------
kernel/signal.c | 7 ++++
13 files changed, 162 insertions(+), 58 deletions(-)

Ok, this series looks good to me - does anyone have any objections?

Thanks, Ingo!

There is a nitpick from Andy about checking both vm_ops and
vm_private_data to avoid (unlikely) confusion with some other VMA
in map_vdso_once().
I'll fix that for the next version, which will be ready to be applied,
if no one has any other objections.

--
Dmitry