Re: [PATCH 5/7] serial: 8250_fintek: Add F81216 Support

From: Ricardo Ribalda Delgado
Date: Thu Sep 01 2016 - 07:23:24 EST


Hi Peter

On Thu, Sep 1, 2016 at 5:39 AM, Ji-Ze Hong (Peter Hong)
<hpeter@xxxxxxxxx> wrote:

> int fintek_8250_probe(struct uart_8250_port *uart)
> {
> struct fintek_8250 *pdata;
> @@ -248,8 +270,8 @@ int fintek_8250_probe(struct uart_8250_port *uart)
> return -ENOMEM;
>
> memcpy(pdata, &probe_data, sizeof(probe_data));
> - uart->port.rs485_config = fintek_8250_rs485_config;

Maybe just:


if (pdata->id != CHIP_ID_F81216)
uart->port.rs485_config = fintek_8250_rs485_config;


Instead of the whole function

> uart->port.private_data = pdata;
> + fintek_8250_set_rs485_handler(uart);
>
> return 0;
> }
> --
> 1.9.1
>



--
Ricardo Ribalda