Re: [PATCH v3 5/5] net: asix: autoneg will set WRITE_MEDIUM reg

[Eric Dumazet]

On Mon, 2016-08-29 at 09:32 -0400, robert.foss@xxxxxxxxxxxxx wrote:
> From: Robert Foss <robert.foss@xxxxxxxxxxxxx>
> 
> From: Grant Grundler <grundler@xxxxxxxxxxxx>
> 
> The miii_nway_restart() causes a PHY link change activity and
> ax88772_link_reset will be called. link_reset will set
> AX_CMD_WRITE_MEDIUM_MODE register correctly.
> 
> The asix_write_medium_mode in reset() fills in a default value to the register
> which may be different from the negotiation result. So do this first.
> 
> Ignore the ret value since it's ignored in XXX_link_reset() functions.
> 
> Signed-off-by: Grant Grundler <grundler@xxxxxxxxxx>
> Signed-off-by: Robert Foss <robert.foss@xxxxxxxxxxxxx>
> Tested-by: Robert Foss <robert.foss@xxxxxxxxxxxxx>
> ---

This is _really_ confusing Robert.

Why having two 'From:' clauses ?

Who wrote the patch in the first place ? You or Grant ?



End result is :

commit 535baf8588d04b177cb33700f81499f2b5203c2d
Author: Robert Foss <robert.foss@xxxxxxxxxxxxx>
Date:   Mon Aug 29 09:32:19 2016 -0400

    net: asix: autoneg will set WRITE_MEDIUM reg
    
    From: Grant Grundler <grundler@xxxxxxxxxxxx>
    
    The miii_nway_restart() causes a PHY link change activity and
    ax88772_link_reset will be called. link_reset will set
    AX_CMD_WRITE_MEDIUM_MODE register correctly.
    
    The asix_write_medium_mode in reset() fills in a default value to the register
    which may be different from the negotiation result. So do this first.
    
    Ignore the ret value since it's ignored in XXX_link_reset() functions.
    
    Signed-off-by: Grant Grundler <grundler@xxxxxxxxxx>
    Signed-off-by: Robert Foss <robert.foss@xxxxxxxxxxxxx>
    Tested-by: Robert Foss <robert.foss@xxxxxxxxxxxxx>
    Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>



I guess Grant wrote the patch, but attribution is wrong.