Re: [linux-sunxi] Re: [PATCH v9 1/2] ASoC: sun4i-codec: Distinguish sun4i from sun7i

[Maxime Ripard]

Hi Danny,

On Wed, Aug 31, 2016 at 10:14:02PM +0200, Danny Milosavljevic wrote:
> Hi Maxime,
> 
> On Wed, 31 Aug 2016 19:46:23 +0200
> Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx> wrote:
> 
> > > -#define SUN4I_CODEC_AC_SYS_VERI			(0x38)
> > > -#define SUN4I_CODEC_AC_MIC_PHONE_CAL		(0x3c)
> > > +
> > > +#define SUN7I_CODEC_AC_DAC_CAL			(0x38)
> > > +#define SUN7I_CODEC_AC_MIC_PHONE_CAL		(0x3c)  
> > 
> > That will need at least some mention in the commit log.
> 
> Hm? It's now called like it is called in the user manual.
> Also, the macro SUN4I_CODEC_AC_SYS_VERI was unused before anyway.
> 
> What should I write in the commit log?

For example, that the current code was wrong and those registers are
not present on the A10.

That way, you justify both the renaming, and the max_register change
in the regmap.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Attachment: signature.asc
Description: PGP signature