Re: [PATCH] staging: ks7010: fix coding style issues in ks7010_sdio.c
From: Greg KH
Date: Thu Sep 01 2016 - 17:57:09 EST
On Thu, Sep 01, 2016 at 11:18:15PM +0530, Sabitha George wrote:
> This is a patch to the ks7010_sdio.c that fixes the following
> warnings found by checkpatch.pl
> 1) Missing a blank line after declarations
> 2) braces are not necessary for single statement blocks
> 3) kfree(NULL) is safe and this check is probably not required
> 4) void function return statements are not generally useful
> 5) "foo * bar" should be "foo *bar"
> 6) Code indent should use tabs where possible
> 7) printk() should include KERN_ facility level
That's 7 different things, so this should be at least 7 different
patches :)
Please break this up and submit it as a patch series so it can be easily
reviewed and applied.
thanks,
greg k-h