Re: [PATCH 2/2] genirq: Generic chip: factorise code using irq_get_domain_generic_chip()

From: Thomas Gleixner
Date: Fri Sep 02 2016 - 11:44:35 EST


On Mon, 1 Aug 2016, Sebastian Frias wrote:
> @@ -350,10 +350,10 @@ irq_get_domain_generic_chip(struct irq_domain *d, unsigned int hw_irq)
> int idx;
>
> if (!dgc)
> - return NULL;
> + return ERR_PTR(-ENODEV);
> idx = hw_irq / dgc->irqs_per_chip;
> if (idx >= dgc->num_chips)
> - return NULL;
> + return ERR_PTR(-EINVAL);

This is completely pointless churn. None of the existing callsites cares
about the error value. We can simply split out the guts into a static
function and keep the semantics for irq_get_domain_generic_chip.

I'll fix that up while applying it.

Thanks,

tglx