Re: [PATCH 2/3] MIPS: OCTEON: add DTS for D-Link DSR-500N

[Sergei Shtylyov]

Hello.

On 9/3/2016 12:11 AM, Aaro Koskinen wrote:

> Add DTS for D-Link DSR-500N.
>
> Signed-off-by: Aaro Koskinen <aaro.koskinen@xxxxxx>
> ---
>  .../mips/boot/dts/cavium-octeon/dlink_dsr-500n.dts | 42 ++++++++++++++++++++++
>  1 file changed, 42 insertions(+)
>  create mode 100644 arch/mips/boot/dts/cavium-octeon/dlink_dsr-500n.dts
>
> diff --git a/arch/mips/boot/dts/cavium-octeon/dlink_dsr-500n.dts b/arch/mips/boot/dts/cavium-octeon/dlink_dsr-500n.dts
> new file mode 100644
> index 0000000..6cacabb
> --- /dev/null
> +++ b/arch/mips/boot/dts/cavium-octeon/dlink_dsr-500n.dts
> @@ -0,0 +1,42 @@
> +/*
> + * Device tree source for D-Link DSR-500N.
> + *
> + * Written by: Aaro Koskinen <aaro.koskinen@xxxxxx>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */
> +
> +/include/ "dlink_dsr-500n-1000n.dtsi"
> +#include <dt-bindings/gpio/gpio.h>
> +
> +/ {
> +	model = "dlink,dsr-500n";
> +	compatible = "dlink,dsr-500n", "cavium,octeon-3860";
> +
> +	soc@0 {
> +		uart0: serial@1180000000800 {
> +			clock-frequency = <300000000>;
> +		};
> +	};
> +
> +	leds {
> +		compatible = "gpio-leds";
> +
> +		usb {
> +			label = "usb";
> +			gpios = <&gpio 9 GPIO_ACTIVE_LOW>;
> +		};
> +
> +		wps {
> +			label = "wps";

   You don't need LED labels when the are identical to the node names.

[...]

MBR, Sergei