Re: [PATCH 1/3] perf tools: Recognize hugetlb mapping as anon mapping

From: Nilay Vaish
Date: Sat Sep 03 2016 - 11:57:01 EST


On 2 September 2016 at 08:59, Wang Nan <wangnan0@xxxxxxxxxx> wrote:
> Hugetlbfs mapping should be recognized as anon mapping so user has
> a chance to create /tmp/perf-<pid>.map file for symbol resolving. This
> patch utilizes MAP_HUGETLB to identify hugetlb mapping.
>
> After this patch, if perf is started before the program uses huge pages
> starting, perf is able to recognize hugetlb mapping as anon mapping.

Wang, everything in the patch series looks good to me. Just a slight
change that I would suggest for the summary above: replace "program
uses huge pages starting" with "program starts using huge pages".

--
Nilay