A potential race in drivers/staging/speakup/speakup.ko

From: Pavel Andrianov
Date: Mon Sep 05 2016 - 04:51:57 EST


Hi!

There is a potential race in drivers/staging/speakup/speakup.ko.
All operations with global pointers buff_in and buff_out are performed without any locks. Thus, a simultaneous write (via synth_buffer_clear or synth_buffer_add) to the pointers may lead to inconsistent data.

Should a local lock be used here?

--
Pavel Andrianov
Linux Verification Center, ISPRAS
web: http://linuxtesting.org
e-mail: andrianov@xxxxxxxxx