Re: [PATCH v4 15/17] pwm: sti: It's now valid for number of PWM channels to be zero

[Thierry Reding]

On Tue, Aug 16, 2016 at 10:35:06AM +0100, Lee Jones wrote:
> Setting up the STI PWM IP as capture only, with zero PWM-out devices
> is a perfectly valued configuration.  It is no longer okay to assume
> that there must be at least 1 PWM-out devices.  In this patch we make
> the default number of PWM-out devices zero and only configure channels
> explicitly requested.
> 
> Reported-by: Peter Griffin <peter.griffin@xxxxxxxxxx>
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
> ---
>  drivers/pwm/pwm-sti.c | 15 ++++++++++++++-
>  1 file changed, 14 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/pwm/pwm-sti.c b/drivers/pwm/pwm-sti.c
> index fcc80eb..a1319c0 100644
> --- a/drivers/pwm/pwm-sti.c
> +++ b/drivers/pwm/pwm-sti.c
> @@ -483,6 +483,11 @@ static int sti_pwm_probe_dt(struct sti_pwm_chip *pc)
>  	if (!ret)
>  		cdata->cpt_num_devs = num_devs;
>  
> +	if (cdata->pwm_num_devs && !cdata->cpt_num_devs) {

Applied, with this corrected to:

	if (!cdata->pwm_num_devs && !cdata->cpu_num_devs)

as discussed on IRC.

Thanks,
Thierry

Attachment: signature.asc
Description: PGP signature