RE: [PATCH v7 3/4] usb: dwc2: assert phy reset when waking up in rk3288 platform

From: David Laight
Date: Mon Sep 05 2016 - 09:40:10 EST


From: Randy Li
> Sent: 03 September 2016 22:55
...
> + if (of_device_is_compatible(np, "rockchip,rk3288-usb")
> + && (NULL != hsotg->phy->ops->reset))
> + hsotg->phy->ops->reset(hsotg->phy);
> +

Is this the only place ops->reset() is called?
Probably much better to check it first.

if (hsotg->phy->ops->reset
&& of_device_is_compatible(np, "rockchip,rk3288-usb")
hsotg->phy->ops->reset(hsotg->phy);

David