[PATCH] s390/crypto: initialize ret to zero to avoid returning garbage value
From: Colin King
Date: Mon Sep 05 2016 - 12:22:55 EST
From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
static analysis with cppcheck detected that ret is not initialized
and hence garbage is potentially being returned in the case where
prng_data->ppnows.reseed_counter <= prng_reseed_limit.
Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
---
arch/s390/crypto/prng.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/s390/crypto/prng.c b/arch/s390/crypto/prng.c
index 79e3a1f..a21fdf4 100644
--- a/arch/s390/crypto/prng.c
+++ b/arch/s390/crypto/prng.c
@@ -412,7 +412,7 @@ static int prng_sha512_reseed(void)
static int prng_sha512_generate(u8 *buf, size_t nbytes)
{
- int ret;
+ int ret = 0;
/* reseed needed ? */
if (prng_data->ppnows.reseed_counter > prng_reseed_limit) {
--
2.9.3