Re: [PATCH] tpm: move struct tpm_class_ops to drivers/char/tpm/tpm.h

[Jason Gunthorpe]

On Mon, Sep 05, 2016 at 08:44:34AM +0300, Jarkko Sakkinen wrote:
> On Sun, Sep 04, 2016 at 02:14:06PM -0600, Jason Gunthorpe wrote:
> > On Sat, Sep 03, 2016 at 09:26:05AM +0300, Jarkko Sakkinen wrote:
> > > > 
> > > > OK, how would one get the chip instance?
> > 
> > Most subsystems have a get function that returns a kref'd pointer. For
> > TPM all we really need today is a 'get_default_tpm_for_ns' kind of
> > function.
> 
> Sorry, but I have no idea what you are talking about.

Go look at how rtc or net work.

> This does not imply that these structure definitions need to be in
> include/linux/tpm.h since you are talking something that does not exist.

Well, I've been slowly pushing tpm to be more like a standard subystem
for a long time - not all the parts are there yet. A standard
subsystem will have a get/put scheme for tpm_chip.

So, yes, it does not exist, but you should be planning for it to exist
someday..

Jason