Re: [PATCH] rxrpc: remove duplicate 'error' variable

[David Howells]

Arnd Bergmann <arnd@xxxxxxxx> wrote:

> The rxrpc_process_call function has debug code to print a failure code,
> but instead of printing the code from the rxrpc_call structure, it
> prints an uninitialized variable:
> 
> net/rxrpc/call_event.c: In function 'rxrpc_process_call':
> net/rxrpc/call_event.c:879:58: error: 'error' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> 
> This removes the extraneous variable and prints the correct
> code instead.
> 
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> Fixes: f5c17aaeb2ae ("rxrpc: Calls should only have one terminal state")

I've already posted a fix and it's waiting on DaveM.

https://patchwork.ozlabs.org/patch/665550/

http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/commit/?h=rxrpc-rewrite&id=00b5407e427ac2588a2496b92035a94602b3cd1b

David