Re: [PATCH] drm/atmel-hlcdc: mark atmel_hlcdc_crtc_reset() static

[Boris Brezillon]

On Tue, 06 Sep 2016 15:43:45 +0200
Arnd Bergmann <arnd@xxxxxxxx> wrote:

> On Tuesday, September 6, 2016 3:46:16 PM CEST Baoyou Xie wrote:
> > We get 1 warning when building kernel with W=1:
> > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c:390:6: warning: no previous prototype for 'atmel_hlcdc_crtc_reset' [-Wmissing-prototypes]
> > 
> > In fact, this function is only used in the file in which it is
> > declared and don't need a declaration, but can be made static.
> > So this patch marks it 'static'.
> > 
> > Signed-off-by: Baoyou Xie <baoyou.xie@xxxxxxxxxx>
> >   
> 
> Acked-by: Arnd Bergmann <arnd@xxxxxxxx>

Actually, Thierry already posted the same patch a while ago. I just
sent a PR to Dave containing this patch.