Re: [PATCH] security/keys: make BIG_KEYS dependent on stdrng.

From: Kirill Marinushkin
Date: Tue Sep 06 2016 - 12:32:53 EST


> The other thing is that I have been given a conflicting patch (see
> below). Is your fix preferable?

The patch you attached previously is v1; I submitted v2 after review by
Stephan Mueller. I additionally attach it here below.

IMO, the preferable fix depends on your future plan.
If you plan to continue using both ANSI X9.31 DRNG and DRBG - I agree with the
patch suggested by Artem Savkov.
If you plan to reduce using ANSI X9.31 DRNG and use DRBG more widely - I
suggest my patch.

Best Regards,
Kirill

---
>From Kirill Marinushkin <k.marinushkin@xxxxxxxxx>
Subject [PATCH v2] KEYS: fix big_key dependency
Date Tue, 16 Aug 2016 21:51:12 +0200

This patch fixes the following bug:
[oss-security] - panic at big_key_preparse #4.7-r6/rc7 & master

Signed-off-by: Kirill Marinushkin <k.marinushkin@xxxxxxxxx>
---
security/keys/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/security/keys/Kconfig b/security/keys/Kconfig
index f826e87..5bc5114 100644
--- a/security/keys/Kconfig
+++ b/security/keys/Kconfig
@@ -44,7 +44,7 @@ config BIG_KEYS
select CRYPTO
select CRYPTO_AES
select CRYPTO_ECB
- select CRYPTO_RNG
+ select CRYPTO_RNG_DEFAULT