Re: [PATCH v2] arch: all: include: asm: bitops: Use bool instead of int for all bit test functions

[Andrew Morton]

On Sun, 4 Sep 2016 08:27:36 +0800 kbuild test robot <lkp@xxxxxxxxx> wrote:

> [auto build test ERROR on linus/master]
> [also build test ERROR on v4.8-rc4 next-20160825]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> [Suggest to use git(>=2.9.0) format-patch --base=<commit> (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on]
> [Check https://git-scm.com/docs/git-format-patch for more information]
> 
> url:    https://github.com/0day-ci/linux/commits/chengang-emindsoft-com-cn/arch-all-include-asm-bitops-Use-bool-instead-of-int-for-all-bit-test-functions/20160828-230301
> config: s390-default_defconfig (attached as .config)
> compiler: s390x-linux-gnu-gcc (Debian 5.4.0-6) 5.4.0 20160609
> reproduce:
>         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # save the attached .config to linux build tree
>         make.cross ARCH=s390 
> 
> All errors (new ones prefixed by >>):
> 
>    In file included from include/linux/bitops.h:36:0,
>                     from fs/btrfs/extent_io.c:1:
> >> arch/s390/include/asm/bitops.h:176:15: error: unknown type name 'bool'
>     static inline bool
>                   ^
>    arch/s390/include/asm/bitops.h:187:15: error: unknown type name 'bool'
>     static inline bool

My s390 cross compiler doesn't like that config.  Can someone test this?

--- a/arch/s390/include/asm/bitops.h~a
+++ a/arch/s390/include/asm/bitops.h
@@ -40,6 +40,7 @@
 #error only <linux/bitops.h> can be included directly
 #endif
 
+#include <linux/types.h>
 #include <linux/typecheck.h>
 #include <linux/compiler.h>
 #include <asm/barrier.h>
_