Re: [PATCH v2 4/5] gpio: pca953x: remove an unused variable

[Andy Shevchenko]

On Wed, 2016-09-07 at 11:24 +0200, Bartosz Golaszewski wrote:
> The chip_type variable in struct pca953x_chip is no longer required.
> 
> Remove it.

Would it be patch 4 in the series?

> 
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
> ---
> Âdrivers/gpio/gpio-pca953x.c | 5 +----
> Â1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
> index 6b62898..00bb2ea 100644
> --- a/drivers/gpio/gpio-pca953x.c
> +++ b/drivers/gpio/gpio-pca953x.c
> @@ -129,7 +129,6 @@ struct pca953x_chip {
> Â	struct i2c_client *client;
> Â	struct gpio_chip gpio_chip;
> Â	const char *const *names;
> -	int	chip_type;
> Â	unsigned long driver_data;
> Â
> Â	const struct pca953x_offset *offset;
> @@ -760,8 +759,6 @@ static int pca953x_probe(struct i2c_client
> *client,
> Â		}
> Â	}
> Â
> -	chip->chip_type = PCA_CHIP_TYPE(chip->driver_data);
> -
> Â	mutex_init(&chip->i2c_lock);
> Â
> Â	/* initialize cached registers from their original values.
> @@ -774,7 +771,7 @@ static int pca953x_probe(struct i2c_client
> *client,
> Â	else if (chip->gpio_chip.ngpio >= 24)
> Â		chip->write_regs = pca953x_write_regs_24;
> Â
> -	if (chip->chip_type == PCA953X_TYPE)
> +	if (PCA_CHIP_TYPE(chip->driver_data) == PCA953X_TYPE)
> Â		ret = device_pca953x_init(chip, invert);
> Â	else
> Â		ret = device_pca957x_init(chip, invert);

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy