Re: [PATCH v2 0/5] perf, bts: Fallout from the fuzzer for perf/urgent

From: Vince Weaver
Date: Wed Sep 07 2016 - 11:33:45 EST


On Wed, 7 Sep 2016, Alexander Shishkin wrote:

> Sure. And yes, I did catch a warning, which calls for one more patch
> (below). Also one unrelated thing in PEBS that Peter fixed.

Does that fix this which I just got on my skylake machine (4.8-rc5 with
your other 5 patches applied)

[ 5351.822559] WARNING: CPU: 3 PID: 19191 at arch/x86/events/intel/bts.c:344 event_function+0xa1/0x160
[ 5351.823895] CPU: 3 PID: 19191 Comm: perf_fuzzer Not tainted 4.8.0-rc5+ #3
[ 5351.823896] Hardware name: LENOVO 10FY0017US/SKYBAY, BIOS FWKT53A 06/06/2016
[ 5351.823897] 0000000000000086 000000001a69ecd3 ffffffff8cf1f9f5 0000000000000000
[ 5351.823898] 0000000000000000 ffffffff8cc7b624 ffffcaa8ffcc26f0 ffff9c676e1aba00
[ 5351.823900] ffff9c6771222800 0000000000000000 ffff9c676e1aba00 ffff9c676f6f7e40
[ 5351.823901] Call Trace:
[ 5351.823905] [<ffffffff8cf1f9f5>] ? dump_stack+0x5c/0x77
[ 5351.823907] [<ffffffff8cc7b624>] ? __warn+0xc4/0xe0
[ 5351.823909] [<ffffffff8cd624d1>] ? event_function+0xa1/0x160
[ 5351.823910] [<ffffffff8cd69db0>] ? ctx_resched+0x50/0x50
[ 5351.823911] [<ffffffff8cd63a3a>] ? remote_function+0x3a/0x40
[ 5351.823913] [<ffffffff8ccfaecd>] ? generic_exec_single+0x9d/0x100
[ 5351.823914] [<ffffffff8ccfaea1>] ? generic_exec_single+0x71/0x100
[ 5351.823916] [<ffffffff8cd63a00>] ? perf_cgroup_attach+0x70/0x70
[ 5351.823917] [<ffffffff8ccfaffd>] ? smp_call_function_single+0xcd/0x130
[ 5351.823918] [<ffffffff8ccfaffd>] ? smp_call_function_single+0xcd/0x130
[ 5351.823919] [<ffffffff8cd628b9>] ? task_function_call+0x49/0x70
[ 5351.823920] [<ffffffff8cd62430>] ? cpu_clock_event_read+0x10/0x10
[ 5351.823921] [<ffffffff8cd67438>] ? event_function_call+0x98/0x100
[ 5351.823922] [<ffffffff8cd69db0>] ? ctx_resched+0x50/0x50
[ 5351.823923] [<ffffffff8cd67530>] ? perf_event_disable+0x30/0x30
[ 5351.823924] [<ffffffff8cd62642>] ? perf_event_for_each_child+0x32/0x90
[ 5351.823925] [<ffffffff8cd6aa51>] ? perf_event_task_enable+0x61/0xb0
[ 5351.823927] [<ffffffff8cc9066e>] ? SyS_prctl+0x2ae/0x470
[ 5351.823929] [<ffffffff8cc03b6f>] ? do_syscall_64+0x5f/0x160
[ 5351.823930] [<ffffffff8d1e7b65>] ? entry_SYSCALL64_slow_path+0x25/0x25
[ 5351.823931] ---[ end trace bc7b0b7d0c024d60 ]---