Re: [RFC PATCH v2 07/20] x86: Provide general kernel support for memory encryption
From: Borislav Petkov
Date: Wed Sep 07 2016 - 11:55:44 EST
On Wed, Sep 07, 2016 at 09:30:54AM -0500, Tom Lendacky wrote:
> _PAGE_ENC is #defined as sme_me_mask and sme_me_mask has already been
> set (or not set) at this point - so it will be the mask if SME is
> active or 0 if SME is not active.
Yeah, I remember :-)
> sme_early_init() is merely propagating the mask to other structures.
> Since early_pmd_flags is mainly used in this file (one line in
> head_64.S is the other place) I felt it best to modify it here. But it
> can always be moved if you feel that is best.
Hmm, so would it work then if you stick it in early_pmd_flags'
definition like you do with the other masks? I.e.,
pmdval_t early_pmd_flags = __PAGE_KERNEL_LARGE | _PAGE_ENC & ~(_PAGE_GLOBAL | _PAGE_NX);
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.