Re: [GIT PULL] usercopy fixes for v4.8-rc6
From: Linus Torvalds
Date: Wed Sep 07 2016 - 12:34:02 EST
Pulled, but:
On Tue, Sep 6, 2016 at 12:37 PM, Kees Cook <keescook@xxxxxxxxxxxx> wrote:
>
> Kees Cook (3):
> usercopy: fold builtin_const check into inline function
Hmm. So with this, check_object_size() seems sane, but it's only
marked "inline".
And we've had the issue that without the __always_inline, gcc will
randomly not inline things. In fact, this very pull added that to the
copy_xyz_user() functions exactly because of this issue.
Now, it may be that check_object_size() is so simple that it really
always *will* be inlined regardless, but it looks a bit dodgy.
Linus