Re: [PATCH] soc: fsl/qe: fix gpio save_regs functions

From: Linus Walleij
Date: Wed Sep 07 2016 - 18:06:19 EST


On Tue, Sep 6, 2016 at 12:52 AM, Christophe Leroy
<christophe.leroy@xxxxxx> wrote:

> of_mm_gpiochip_add_data() calls mm_gc->save_regs() before
> setting the data. Therefore ->save_regs() cannot use
> gpiochip_get_data()
>
> An Oops is encountered without this fix.
>
> fixes: 1e714e54b5ca5 ("powerpc: qe_lib-gpio: use gpiochip data pointer")
> Signed-off-by: Christophe Leroy <christophe.leroy@xxxxxx>
> Cc: <stable@xxxxxxxxxxxxxxx>

Aha sorry for my regular screwups. :(
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij